Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 15 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 2 files changed, 15 insertions(+), 5 deletions(-))

Tests analytics

Total tests: 97
Passed tests: 76
Skipped tests: 14
Affected tests: 7

Action taken

Get to know how VCR tests work

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceSqlDatabase_basic[Debug log]
TestAccDataSourceSqlDatabases_basic[Debug log]
TestAccSQLDatabase_sqlDatabaseBasicExample[Debug log]
TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample[Debug log]
TestAccSqlDatabaseInstance_multipleOperations[Debug log]
TestAccSqlDatabase_basic[Debug log]
TestAccSqlDatabase_update[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Hi @SarahFrench Added the tests and verified it locally as well to verify the functionality.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 73 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 73 insertions(+), 5 deletions(-))

Tests analytics

Total tests: 99
Passed tests: 84
Skipped tests: 15
Affected tests: 0

Tests were added that are skipped in VCR:

• TestAccSqlUser_instanceWithActivationPolicy
  🟢 All tests passed!

View the build log

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 75 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 3 files changed, 75 insertions(+), 5 deletions(-))

Tests analytics

Total tests: 99
Passed tests: 84
Skipped tests: 15
Affected tests: 0

Tests were added that are skipped in VCR:

• TestAccSqlUser_instanceWithActivationPolicy
  🟢 All tests passed!

View the build log

For future reference by maintainers, here's a build running that acc tess with the latest code: BUILD

Thanks @SarahFrench for the suggested code changes. Updated the unit test for both user and database.

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 139 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 4 files changed, 135 insertions(+), 5 deletions(-))

Tests analytics

Total tests: 100
Passed tests: 84
Skipped tests: 15
Affected tests: 1

🔴 Tests were added that are skipped in VCR:

• TestAccSqlUser_instanceWithActivationPolicy

Action taken

Get to know how VCR tests work

🟢 Tests passed during RECORDING mode:
TestAccSqlDatabase_instanceWithActivationPolicy[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

I'm just running the skipped test again to confirm everything's ok. Assuming it passes I'll approve and merge. Thank you for the additional test!

Final note on this PR for any future reference:

I've set the release note to

sql: updated google_sql_database and google_sql_user so they don't perform Read operations if their associated google_sql_database_instance has activation_policy set to "NEVER". This avoids triggering API errors while the instance is unavailable.

This PR doesn't prevent create/update/delete actions as the API error is useful in those cases. We need to skip Read when the instance isn't available, as the instance isn't queryable then. There may be Terraform configurations that are valid and contain a google_sql_database_instance with other child resources, and then activation_policy is temporarily set to "NEVER". In those cases refresh actions will trigger API errors. When the instance is returned to being available then the child resources will resume as normal.